feat: record spend block and timestamp on notes - #29
Merged
Merged
Conversation
…block_number and spent_timestamp columns to the notes table so a spend can be ordered independently of the note's creation block
bhflm
marked this pull request as ready for review
August 7, 2026 21:22
mattgle
self-requested a review
August 10, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add nullable spent_block_number and spent_timestamp columns to the notes
table so a spend can be ordered independently of the note's creation block.
Widen markNoteSpent and markNotesSpentBatch to persist them.