Return all transaction history rows unless a limit is asked for - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
getTxHistorydefaultedlimitto 100. TheWalletStorageinterface declares that parameter optional and documents no cap, so a caller that omitted it silently received at most 100 rows while the declared contract promised the wallet's history for that chain.Truncation gave no signal.
getTxHistory(walletId, chainId)reads as exhaustive at the call site and was not. It is also the only query in the package that caps its own result set, and no caller passes a limit today.Overview
Omitting
limitreturns every row. Passing one still limits to that many. The parameter stays available for a caller that genuinely wants fewer rows, so this removes the silent default rather than the capability.The guard lives in the driver-neutral contract suite, so the guarantee holds for every adapter rather than the node one alone.