Bump @noble/hashes to v2 and add browser checks - #30
Merged
Merged
Conversation
bhflm
approved these changes
Jul 31, 2026
mattgle
force-pushed
the
feat/platform-neutrality-proof
branch
from
July 31, 2026 14:20
6b24c51 to
c670973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
@noble/hasheswith the rest of the SDK.Cryptography and curves are already on v2, and verifies the package resolves for the browser.
@noble/hashes1.8 → 2.2. v2 publishes only.jssubpaths, so import specifiers carry the extension.sha512HMACgains RFC 4231 vectors, including two 131-byte-key cases covering key pre-hashing above SHA-512's 128-byte block. The previous over-length-key test asserted only digest length, which a silently truncated key would also satisfy.@railgun-reloaded/0zk-addresseslockfile pin was frozen at a commit predating that package'snode:assert/strictremoval, so the resolved dependency graph still contained a Node builtin. Refreshed to current dev.check:browserandcheck:packageadded and wired into CI.