refactor: export shield signature message as a standalone constant - #31
Merged
Merged
Conversation
bhflm
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
RAILGUN_SHIELD— the message a public wallet signs to derive a shield private key — was only reachable through theRailgunWallet.getShieldPrivateKeySignatureMessage()static. Downstream packages that need the constant but not a wallet instance were re-declaring it locally, which puts a correctness-critical value in more than one place: a mismatch produces a valid-looking 32-byte key with no error, and the resulting shield is simply undecryptable.It is now
SHIELD_PRIVATE_KEY_SIGNATURE_MESSAGE, exported fromnotes/shield-note.tsand through the package entry point. Placing it next toShieldNotemeans consumers already importing that module pick it up at no extra cost.breaking
RailgunWallet.getShieldPrivateKeySignatureMessage()is removed. Import the constant instead.