fix: assert empty stderr, trust mise in app dir#352
Merged
iloveitaly merged 14 commits intorailwayapp:mainfrom Nov 20, 2025
Merged
Conversation
iloveitaly
force-pushed
the
claude/assert-empty-stderr-tests-011CV611yLzrr4AfQSsgDciJ
branch
5 times, most recently
from
1650c92 to
3824c83
Compare
iloveitaly
changed the title
iloveitaly
force-pushed
the
claude/assert-empty-stderr-tests-011CV611yLzrr4AfQSsgDciJ
branch
2 times, most recently
from
b5a75dd to
1476acd
Compare
Add assertion to check that stderr is empty when integration tests pass successfully. This helps catch unexpected warnings or error messages that might indicate issues even when the test technically succeeds. The check is added to runContainerWithTimeout which runs containers that output expected strings. HTTP check tests are not affected since they already validate correctness via HTTP requests and separating stderr from detached containers is more complex.
Add "private": true to all example package.json files to suppress package manager warnings about missing license fields. These are test/example projects not meant to be published to npm registries. This prevents stderr warnings like "warning package.json: No license field" which were causing the new stderr assertion in integration tests to fail even though the applications were running correctly. Affected examples: - All node-yarn-* examples - node-npm, node-pnpm, node-bun examples - config-file, mise-config examples - Other node-based examples
Add MISE_TRUSTED_CONFIG_PATHS=/app to automatically trust mise configuration files in the application directory during builds. This prevents trust warnings when MISE_PARANOID mode is enabled: "Trust them with \`mise trust\`. See https://mise.jdx.dev/cli/trust.html" Since the app directory (/app) is the user's code being built, it's safe to trust mise configuration files located there.
Add optional "stderrAllowed" field to test.json that defaults to false. When set to true, skips the stderr empty assertion for tests where stderr output is expected and normal. This is useful for applications that log to stderr by default, such as gunicorn which outputs info logs to stderr: [2025-11-18 18:13:50 +0000] [1] [INFO] Starting gunicorn 23.0.0 [2025-11-18 18:13:50 +0000] [1] [INFO] Listening at: http://0.0.0.0:3333 (1) Updated python-uv test to set stderrAllowed: true since it uses gunicorn which logs to stderr.
Add stderrAllowed: true to node-latest-npm-native-deps test to handle the NPM_CONFIG_PRODUCTION deprecation warning: "npm warn config production Use \`--omit=dev\` instead" This is temporary and should be removed once NPM_CONFIG_PRODUCTION is removed from core/providers/node/node.go:241 in a separate PR.
Add stderrAllowed: true to node-prisma, node-remix, and node-npm-install-in-build test cases to temporarily allow the npm warning about NPM_CONFIG_PRODUCTION being deprecated. This is a temporary workaround until NPM_CONFIG_PRODUCTION is removed from node.go in a separate PR.
Bun routes console.log/console.error to stderr by default in script mode. Add stderrAllowed: true to all Bun example tests to allow this expected behavior.
TanStack Start outputs to stderr during server startup. Add stderrAllowed: true to allow this expected behavior.
iloveitaly
force-pushed
the
claude/assert-empty-stderr-tests-011CV611yLzrr4AfQSsgDciJ
branch
from
b2ff71c to
22fbaee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.