Open
Conversation
iloveitaly
requested changes
Mar 9, 2026
Collaborator
iloveitaly
left a comment
There was a problem hiding this comment.
Wow, thanks for all of your hard work here! Sorry for how long it's taken me to review.
- I'm not sure if we want to add DENO_VERSION, etc. The versions can be customized via
mise.tomland I'd rather not add additional logic for these lesser-used languages. Let's remove any config option additions from this PR. - I'd rather keep the config structs in the provider file, unless there's a good reason not to. An exception could be more complicated providers like Node.
- I haven't looked into if this is possible with Go, but what I'd like to do is (a) set the config options in a struct (b) have a helper that for a given key on the struct generates a consistent ENV var name.
StaticfileConfig.root=>STATICFILE_ROOT=>RAILPACK_STATICFILE_ROOT(viaGetConfigVariable)
I'll have some more comments later, but wanted to get you some initial thoughts before I have time to think this through in more detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
The goal of this PR is to support provider specific configuration in the config file.
{ "elixir": { "version": "1.16.3-otp-26", "erlangVersion": "27.3" } }Issue #218
This change supports all existing provider config options.
This a new option for provider configuration and does not change existing behavior.
Testing these changes
Unit tests were added to validate each provider and config option.
Manual testing was done for each provider using the plan command.
I created a config file for each provider in the example apps (not committed) and ensured the new config options affected the output.
Future improvements