fix: preserve --env secrets when config defines secrets#460
Open
cadeljones wants to merge 1 commit intorailwayapp:mainfrom
Open
fix: preserve --env secrets when config defines secrets#460cadeljones wants to merge 1 commit intorailwayapp:mainfrom
cadeljones wants to merge 1 commit intorailwayapp:mainfrom
Conversation
Union env-derived secret names with merged config secrets so file-level no longer drops build-time env vars. Add a regression test that covers this merge behavior.
Collaborator
|
@cadeljones thanks for this—great fix. Two things I need to do before I can merge this:
If you have time to do those, great! If not, I'll get them when I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--envsecrets when config file also defines secrets by merging both sources instead of replacing one with the other.core/core_test.goto prevent regressions.Context
secretsin config file removes all other environment variables from build steps #455