Repository navigation
fix(cli): show the mascot during cached reports - #52
Merged
Merged
Conversation
Record why interactive reports stopped parsing Cursor on every run, which releases changed the plan versus the schedule, and the v0.7.18 cache measurements on this machine. Full Cursor scans were not re-run.
Cache hits never entered scanHUD, so a multi-second report printed nothing until it finished. Arm the existing sprite after 140ms, keep it off JSON, quiet, pipes, and dumb terminals, and erase it before the result is written.
Record when the mascot appears, when it stays off, and the PTY timings that separate first visible output from the unchanged aggregate.
Run the real update path from v0.7.18 to a build of this commit on the native runner, including a second update and a rejected checksum. It does not tag or publish.
The race detector flagged TestWaitHUDAnimatesBeforeFinish for calling bytes.Buffer.String while the HUD goroutine was still painting. The frames are still in the buffer after finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pricing --usagearm the existing mascot after 140ms. JSON, quiet, pipes, andTERM=dumbstay quiet. The sprite is erased before the result is written.docs/performance.mdrecords why reports got faster (index read and fewer scans, not a cheaper aggregate) and the measurements from this machine.scripts/candidate-upgrade.shupdates a published v0.7.18 binary to a local candidate. It does not tag or publish.Not done
Test
go test ./...andgo vet ./...passed locally.TestPTYShowsMascotBeforeFinishpassed on darwin.--quietstayed in the same multi-second band.bash scripts/candidate-upgrade.shon darwin/arm64 printedcandidate upgrade PASS.