Skip to content

Bump rain.metadata submodule#483

Open
findolor wants to merge 2 commits intomainfrom
chore/rain-metadata-submodule-update-audit-base
Open

Bump rain.metadata submodule#483
findolor wants to merge 2 commits intomainfrom
chore/rain-metadata-submodule-update-audit-base

Conversation

@findolor
Copy link
Copy Markdown
Contributor

@findolor findolor commented Apr 28, 2026

Motivation

Update the rain.metadata submodule from the audit base commit so downstream metadata changes are available without including unrelated updates.

Solution

  • Bump lib/rain.metadata to 0cfba664c5a381662ed4436979ad47e12e76c2a8.
  • Update foundry.lock to match the submodule revision.

Checks

  • Inspected git diff main...HEAD for foundry.lock and lib/rain.metadata.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest revisions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • foundry.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0dc34b4a-54b1-4424-8015-ddd843ba863d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

A submodule reference in lib/rain.metadata is updated to point to a new commit SHA, advancing the checked-in dependency to a more recent revision.

Changes

Cohort / File(s) Summary
Submodule Reference
lib/rain.metadata
Updated submodule commit pointer to new revision.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hop, hop, one pointer takes flight,
A submodule's commit shines bright!
One line out, one line in with care,
Rain.metadata updates with flair! 🌧️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump rain.metadata submodule' directly and clearly describes the main change in the pull request, which is updating the rain.metadata submodule reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rain-metadata-submodule-update-audit-base

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor findolor self-assigned this Apr 28, 2026
@findolor findolor requested review from JuaniRios and hardyjosh April 28, 2026 12:15
…ubmodule-update-audit-base

# Conflicts:
#	foundry.lock
graphite-app Bot pushed a commit to rainlanguage/raindex that referenced this pull request May 11, 2026
…erBuilder (#2479)

## Dependent PRs
- rainlanguage/specs#46
- rainlanguage/rain.strategies#89
- rainlanguage/rainlang#483

## Motivation

The order builder logic (formerly "GUI") lived entirely in `crates/js_api/src/gui/`, tightly coupled to WASM and `JsValue`. This made it impossible to reuse from the CLI, REST API, or other Rust consumers. Additionally, the "GUI" naming was misleading since the logic is not UI-specific — it handles field values, deposits, token selection, state serialization, and order calldata generation.

## Solution

- **Ported core logic to `crates/common/src/raindex_order_builder/`** — field values, deposits, select tokens, order operations, state management, and validation now live in a platform-agnostic common crate with no WASM dependencies.
- **Reduced `crates/js_api/src/raindex_order_builder/`** to thin WASM wrappers that delegate to the common crate, keeping only `JsValue` conversion and callback handling.
- **Renamed all GUI terminology to OrderBuilder** across the entire codebase:
  - Rust types: `DotrainOrderGui` → `RaindexOrderBuilder`, `DotrainGuiStateV1` → `OrderBuilderStateV1`, `GuiCfg` → `OrderBuilderCfg`, etc.
  - YAML keyword: `gui:` → `builder:`
  - Settings crate: `gui.rs` → `order_builder.rs`
  - Svelte/TS: components, providers, hooks, tests, and documentation updated
  - Test file renamed: `gui.test.ts` → `builder.test.ts`
  - WASM getter: `dotrainGuiState` → `orderBuilderState`
- **Bumped `lib/rain.interpreter` submodule** to pull in `OrderBuilderStateV1` rename from `rain.metadata`.
- Updated all ARCHITECTURE.md files and README documentation.

## Checks

By submitting this for review, I'm confirming I've done the following:
- [ ] made this PR as small as possible
- [ ] unit-tested any new functionality
- [x] linked any relevant issues or PRs
- [ ] included screenshots (if this involves a front-end change)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **New Features**
  - Replaces the GUI surface with a unified "Order Builder": deposits, field values, select-tokens, token info & balances, validation, state serialization/restoration, calldata/deployment-args generation, and related UI provider/hook + WASM/JS bindings.

* **Documentation**
  - README and architecture docs updated to show builder-centric examples and workflow.

* **Chores**
  - Added encoding/hash utility dependencies (base64, bincode, sha2).
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants