Fit isketch to phones and tablets - #83
Merged
Merged
Conversation
Points keep a stylus's pressure as x,y,p, drawn as a filled outline with perfect-freehand in the app and in SVG. Once a stylus has drawn, touch never draws.
Below 768px the tool bar docks at the bottom and panels become sheets. Two fingers pinch and pan anywhere, a long press or right click opens a context menu, and a link opened on a phone shows a fitted read-only view. Phone and tablet Playwright projects run the touch specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FL-81.
useTwoFingers), because Vue Flow's zoom never sees a gesture that starts on a shape (d3-drag stops the touch), and on a phone shapes cover most of the screen.contextmenu) or a right click: Open details, Rename, Duplicate, Delete; Edit label and Remove for a connection.x,y,p) and drawn as a filled outline with perfect-freehand, in the app and the SVG renderer; once a stylus has drawn, touch never draws (palm rejection).phone(Pixel 7) andtablet(Galaxy Tab S4 landscape) projects rune2e/mobile/touch.spec.js, using CDP for real two-finger and long-press touches. e2e 119 passed, vitest 247, lint and typecheck; checked by screenshot at 360px, Pixel 7 and tablet.