Repository navigation
Name the source link GitHub and give it the mark - #84
Merged
Merged
Conversation
"Source" did not say where the link went. The mark and the name together do, before it is clicked. The label stays visible so it does not rely on the icon alone.
The video link sat directly under the commented-out screenshot with a double blank line after it, which Prettier rejects. CI checks the merge with main, so this failed every open pull request. Whitespace only: the video link and the commented-out screenshot are unchanged.
raj-khan
added a commit
that referenced
this pull request
Sep 19, 2026
"Source" did not say where the link went. The mark and the name together do, before it is clicked. The label stays visible so it does not rely on the icon alone. Also fixes README spacing so format:check passes: the promo video link sat under the commented-out screenshot with a double blank line after it, which failed verify on every open pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The footer link said "Source", which does not tell anyone where it goes. Now it carries the GitHub mark and reads "GitHub", so it is recognisable before it is clicked.
Notes
The mark is inline rather than from lucide-react, which dropped its brand icons. Inline also means it inherits
currentColorand costs no extra request.The text label stays visible rather than being replaced by the icon, so the link does not depend on recognising a logo, and it keeps its accessible name without needing
aria-label.The URL now comes from
REPO_URLinlib/site.tsinstead of being written out a second time.Checks
npm run lint,npm run format:check,npm run typecheck,npm test(465 passed),npm run buildand the Playwright suite (34 tests) all pass.Also in this PR: a README fix
The commit
01d241don main left the promo video link directly under the commented-out screenshot with a double blank line after it, which Prettier rejects. Because CI checks the merge with main, that failedverifyon every open pull request. Fixed here so this one can land.Whitespace only: the video link and the commented-out screenshot are unchanged.