Record that upstream has been unmaintained since 2021 - #5
Merged
Conversation
The fork notice said what this fork changed but not why it exists as a fork rather than a branch. Upstream's last commit is 2021-12-29; the pull requests open against it go back to 2020, and two of them are directly relevant — one proposes the same .NET Core migration this fork carried out, and one bumps log4net for the advisory this repository has already patched. Worth stating explicitly because the repository page says "14 commits behind tech-software/TDSProxy:master", which reads as a backlog and is not one: that is upstream's entire history, counted as missing because the squashed history here shares no merge base with it. GitHub would report the same number if the two trees were identical. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9JVxmeMMFL7bRGq4vbbgf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one paragraph to the fork notice in the README.
The notice said what this fork changed but not why it exists as a fork rather than a branch. Upstream's last commit is 2021-12-29. The PRs open against it go back to 2020, and two are directly relevant:
Worth stating because the repo page reads "14 commits behind tech-software/TDSProxy:master", which looks like a backlog and is not one. Fourteen is upstream's entire history, counted as missing because the squashed history here shares no merge base with it:
GitHub would report the same number if the two trees were byte-identical. Verified separately that the squash captured upstream's tip rather than an older state:
TDSListener.cshere contains the accept-loop fix from upstream's final commit and extends well past it.