Remove py2 compat - #32
Open
ralphm wants to merge 11 commits into
Open
Conversation
ralphm
marked this pull request as draft
May 24, 2021 17:40
ralphm
marked this pull request as ready for review
May 25, 2021 12:07
Owner
Author
|
@goffi-contrib: care to take a look at this? |
|
@ralphm sure, checking it now. |
goffi-contrib
approved these changes
May 26, 2021
craigds
reviewed
Jun 24, 2021
craigds
left a comment
craigds
left a comment
There was a problem hiding this comment.
The code looks 👍 to me.
I'd suggest adding to setup.py:
Programming Language :: Python :: 3 :: Onlyclassifier- a
python_requireskwarg, so that users with older versions of python don't get a broken install: https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
|
@ralphm Mind merging and releasing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31.