Add support for twisted bindAddress argument - #4
Open
sayoun wants to merge 5 commits into
Open
Conversation
Owner
|
@sayoun: Thanks for the patch! It would be great if you could add some unittests for the these changes, as well as a docstring for the new parameter to |
Add unittest for start/stop service with bindAdress parameter
Author
|
Hello, I added a docstring and a unittest for the new parameter bindAddress. Best Regards. |
- reactor.connectTCP - SRVConnector using XMPPClientConnector
Author
|
Thanks for you feedback, I rewrote the tests according to your message, I hope this time it covers everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
when using servers with multiple interfaces, we need to be able to choose which interface to use for binding the socket for the outgoing connection.
Twisted use an internal argument called bindAddress for this purpose, this pull request add support for this in the XMPP client.
Best Regards.