Skip to content

Add support for twisted bindAddress argument - #4

Open
sayoun wants to merge 5 commits into
ralphm:masterfrom
Gandi:bindAdress
Open

Add support for twisted bindAddress argument#4
sayoun wants to merge 5 commits into
ralphm:masterfrom
Gandi:bindAdress

Conversation

@sayoun

@sayoun sayoun commented Aug 26, 2013

Copy link
Copy Markdown

Hello,

when using servers with multiple interfaces, we need to be able to choose which interface to use for binding the socket for the outgoing connection.

Twisted use an internal argument called bindAddress for this purpose, this pull request add support for this in the XMPP client.

Best Regards.

@ralphm

ralphm commented Aug 26, 2013

Copy link
Copy Markdown
Owner

@sayoun: Thanks for the patch! It would be great if you could add some unittests for the these changes, as well as a docstring for the new parameter to XMPPClient.

Add unittest for start/stop service with bindAdress parameter
@sayoun

sayoun commented Aug 27, 2013

Copy link
Copy Markdown
Author

Hello,

I added a docstring and a unittest for the new parameter bindAddress.
Unittest has a comment explaining why we must use a callLater in order to have the unittest work, because we need to keep the reactor clean between tests otherwise it fails.

Best Regards.

@sayoun

sayoun commented Sep 9, 2013

Copy link
Copy Markdown
Author

Thanks for you feedback,

I rewrote the tests according to your message, I hope this time it covers everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants