fix(player): route non-TorrServer loopback streams to OkHttpDataSource - #2
Open
haaihond wants to merge 1 commit into
Conversation
LocalhostZeroCopyDataSource intercepts 127.0.0.1 and injects Connection: close on every chunk, which breaks container seeks and streaming contexts in non-torrent loopback servers (e.g. Usenet). Scopes zero-copy data source strictly to TorrServer while routing other loopback streams to pooled OkHttpDataSource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up for your buffer PR:
DefaultDataSourceroutes all127.0.0.1traffic intoLocalhostZeroCopyDataSource, which sendsConnection: closeand drops the TCP connection on every container seek.While TorrServer is fine with that, it breaks streaming contexts for persistent local servers (like Usenet or local proxies), increasing MKV startup time.
This commit scopes the zero-copy data source strictly to TorrServer (checking ports 8090/8091 and
?link=), and keeps other loopback streams on pooled OkHttp. Added unit tests to ensure zero regressions for TorrServer and external streams.