Skip to content

Remove redundant variable assignment in connection check#604

Merged
raman325 merged 2 commits intofix-entity-creation-blockingfrom
copilot/sub-pr-602-again
Nov 4, 2025
Merged

Remove redundant variable assignment in connection check#604
raman325 merged 2 commits intofix-entity-creation-blockingfrom
copilot/sub-pr-602-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 4, 2025

Addressed code review feedback to simplify connection checking logic in __init__.py.

Changes:

  • Removed intermediate is_connected variable that was only used once
  • Directly evaluate await lock.async_internal_is_connection_up() in if statement

Before:

is_connected = await lock.async_internal_is_connection_up()
if not is_connected:
    _LOGGER.debug(...)

After:

if not await lock.async_internal_is_connection_up():
    _LOGGER.debug(...)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: raman325 <7243222+raman325@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix entity creation blocking and UI changes based on feedback Remove redundant variable assignment in connection check Nov 4, 2025
Copilot AI requested a review from raman325 November 4, 2025 10:55
@github-actions github-actions Bot added python Pull requests that update Python code labels Nov 4, 2025
@raman325 raman325 marked this pull request as ready for review November 4, 2025 11:00
@raman325 raman325 merged commit 8df5ef9 into fix-entity-creation-blocking Nov 4, 2025
7 checks passed
@raman325 raman325 deleted the copilot/sub-pr-602-again branch November 4, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants