Skip to content

release(1.6.1): accept setuptools sdists and build the pure-python wheel once #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rand-lee merged 1 commit into from
Sep 24, 2026
Merged

release(1.6.1): accept setuptools sdists and build the pure-python wheel once #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/scripts/release_artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,11 +631,12 @@ def _python_distribution_name_from_wheel(path: Path, expected: set[str]) -> str:

def _python_distribution_name_from_sdist(path: Path, expected: set[str]) -> str | None:
with tarfile.open(path, "r:gz") as archive:
metadata = [member for member in archive.getmembers() if member.name.endswith("/PKG-INFO")]
# Root-level PKG-INFO only: setuptools sdists also carry *.egg-info/PKG-INFO (sc-publish#74).
metadata = [m for m in archive.getmembers() if m.name.endswith("/PKG-INFO") and m.name.count("/") == 1]
if not metadata:
return None
if len(metadata) != 1:
raise SystemExit(f"{path}: expected exactly one sdist PKG-INFO file")
raise SystemExit(f"{path}: expected exactly one root-level sdist PKG-INFO file")
extracted = archive.extractfile(metadata[0])
if extracted is None:
raise SystemExit(f"{path}: unable to read sdist PKG-INFO")
Expand Down
2 changes: 1 addition & 1 deletion release/publish-artifacts.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ source = "crates/hermes-atm"
build_system = "setuptools"
module_path = "crates/hermes-atm/src/hermes_atm"
sdist = true
wheels = ["ubuntu-latest", "macos-latest", "windows-latest"]
wheels = ["ubuntu-latest"]

[channels.pypi]
workflow = "pypi-publish.yml"
Expand Down
Loading