release(1.6.1): check out the dispatch ref in the PyPI publish workflow - #1594
Merged
Merged
Conversation
Publish PyPI run 36017176129 checked out the immutable tag v1.6.1 and ran that commit's release_artifacts.py, reproducing the sdist rejection that #1592 fixed on main. The workflow never builds from source; the checkout only supplies the verify tooling and the manifest, so it must come from the dispatched commit (sc-publish#76, the v1.4.4 fix the phase-bc re-render dropped). Release assets are still downloaded by tag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
rand-lee
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish PyPI run 36017176129 for v1.6.1 failed in Select and verify Python distributions with the pre-#1592 error text, although #1592 was on main. Both jobs of
pypi-publish.ymlcheck outref: ${{ inputs.tag }}, so the workflow ran the copy ofrelease_artifacts.pyfrozen at tag v1.6.1 (commit 1272d4c). The release is immutable, so the tag cannot move, and no fix on main can ever reach this workflow while it pins its checkout to the tag.Cause. atm-core's 1.6.0 copy of this workflow carried the v1.4.4 release-branch fix for exactly this (sc-publish#76): check out the dispatch ref, because the workflow never builds from source and the checkout exists only to supply the verify tooling and the manifest. The phase-bc kit re-render (b381e09) restored the tag pin. Same story as #1591 and #1592.
Fix, consumer-side only. Remove
with: ref: ${{ inputs.tag }}from both checkout steps. The release assets are still downloaded by tag; only the tooling comes from the dispatched commit, which is the modelrelease.ymlalready uses.Retry. The publisher re-dispatches Publish PyPI from main with
tag=v1.6.1,target=production. Nothing was uploaded by the failed run, so all three distributions publish fresh. crates.io, the GitHub Release, Homebrew, Scoop and Winget are complete and are not re-run.🤖 Generated with Claude Code