Conversation
randlee
added this pull request to stack #186
September 20, 2026 21:13
This was referenced Sep 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sc-compose JSON autoescape serializes an ordinary string as a JSON string. The carry-forward contract intentionally supplies a pre-serialized JSON array string, so rendering it without an explicit trust-boundary filter changes the value from an array into the string
"[]".This is the surgical port of atm-core commit
37c480f40and the behavior already present in sc-runtime PR #6:| safeonly tocarry_forward_findings_jsonin the seven assignment templates;No agent prose or repository policy changed.
Best-practice rationale
MiniJinja's
safefilter is appropriate here because the input contract explicitly requires a pre-serialized JSON fragment. Native typed values should use JSON serialization instead; this PR does not broadensafeto ordinary strings.Validation
just lint: PASSjust test: PASSgit diff --check: PASS