Fix flakey macho test failures#296
Merged
smcintyre-r7 merged 1 commit intoJul 8, 2026
Merged
Conversation
Contributor
|
The changes make sense and the tests pretty clearly illustrate what the issue is. Verified they pass with the changes and the tests fail without the changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI tests showed a ~6% chance of OSX payloads breaking:
The TL:DR being:
Before: mettle embedded the config block with
String#sub(pattern, replacement), and Ruby interprets backslash sequences (\0,\1, etc.) in the string replacement — so random config bytes containing\+char got expanded or dropped, changing the binary's size and shifting the Mach-O code signature out of place, which broke signing.The fix uses the block form
sub(pattern) { replacement }, which inserts the bytes verbatim without interpreting backreferences, so the binary keeps its exact size and the signature stays valid.