Repository navigation
Update smartmin to 6.2.3 - #274
Merged
Merged
Conversation
Authenticated users without permission now get a 403 rather than a login redirect, so update tests accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates smartmin to the latest release, 6.2.3.
smartmin 6.2.3 now returns a 403 when an authenticated user lacks permission for a view, instead of redirecting them to the login page (which would just bounce them back). Anonymous users are still redirected to login.
Tests asserting a login redirect for logged-in users without permission now assert a 403 instead; assertions for anonymous users are unchanged.