Follow-up to recent cucascade fixes#22510
Conversation
There was a problem hiding this comment.
Are we missing cuda-nvml-dev in the conda recipe? Or is it not needed there?
cudf/conda/recipes/libcudf/recipe.yaml
Line 88 in d7c7891
|
Well, it looks like none of my attempted fixes have worked so far. I need to do some local investigation and will push once I have something that works. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughCUDA NVML development package support is added across multiple conda environment definitions by updating the source dependency manifest and generated environment files for CUDA 12.9 and 13.2 on both aarch64 and x86_64 architectures. CMake CUDA toolkit detection is simultaneously improved to capture nvcc exit status and conditionally create imported targets only when they do not already exist. ChangesCUDA NVML Development Support and CMake Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing in favor of rapidsai/rapidsmpf#1035 |
Description
FindCUDAToolkitas of af0828cbbff5d9b111b7209b46242b9c9ba7865ccuda-nvml-devwhen building devcontainersChecklist