Skip to content

add support for multigraph to disjoint sampling #5520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 7 commits into from
May 20, 2026
Merged

add support for multigraph to disjoint sampling #5520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
919866f
add support for multigraph to disjoint sampling
ChuckHastings May 15, 2026
d0818a4
Merge branch 'release/26.06' into support_multigraph_in_disjoint_samp…
ChuckHastings May 15, 2026
a590963
Refactor deduplicate_edges_by_minor based on PR comments
ChuckHastings May 19, 2026
75fc956
another change, don't need to return result_types, only discarded_types
ChuckHastings May 19, 2026
6208863
Address a few comments I missed in the PR
ChuckHastings May 19, 2026
6a34644
Use edge_type_t where we define it rather than hard-coding int32_t ev…
ChuckHastings May 19, 2026
3c7f3f1
Merge branch 'release/26.06' into support_multigraph_in_disjoint_samp…
ChuckHastings May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
538 changes: 224 additions & 314 deletions cpp/src/sampling/detail/deduplicate_edges_by_minor_impl.cuh
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions cpp/src/sampling/detail/deduplicate_edges_by_minor_mg_v32_e32.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,19 @@ template CUGRAPH_EXPORT std::tuple<rmm::device_uvector<int32_t>,
rmm::device_uvector<int32_t>,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>,
std::optional<rmm::device_uvector<int32_t>>,
rmm::device_uvector<int32_t>,
rmm::device_uvector<int32_t>,
arithmetic_device_uvector_t,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>>
deduplicate_edges_by_minor<int32_t, int32_t, true>(
raft::handle_t const&,
graph_view_t<int32_t, int32_t, false, true> const&,
rmm::device_uvector<int32_t>&&,
rmm::device_uvector<int32_t>&&,
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&,
bool);
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&);

} // namespace detail
} // namespace cugraph
9 changes: 6 additions & 3 deletions cpp/src/sampling/detail/deduplicate_edges_by_minor_mg_v64_e64.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,19 @@ template CUGRAPH_EXPORT std::tuple<rmm::device_uvector<int64_t>,
rmm::device_uvector<int64_t>,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>,
std::optional<rmm::device_uvector<int64_t>>,
rmm::device_uvector<int64_t>,
rmm::device_uvector<int64_t>,
arithmetic_device_uvector_t,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>>
deduplicate_edges_by_minor<int64_t, int64_t, true>(
raft::handle_t const&,
graph_view_t<int64_t, int64_t, false, true> const&,
rmm::device_uvector<int64_t>&&,
rmm::device_uvector<int64_t>&&,
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&,
bool);
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&);

} // namespace detail
} // namespace cugraph
9 changes: 6 additions & 3 deletions cpp/src/sampling/detail/deduplicate_edges_by_minor_sg_v32_e32.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,19 @@ template CUGRAPH_EXPORT std::tuple<rmm::device_uvector<int32_t>,
rmm::device_uvector<int32_t>,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>,
std::optional<rmm::device_uvector<int32_t>>,
rmm::device_uvector<int32_t>,
rmm::device_uvector<int32_t>,
arithmetic_device_uvector_t,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>>
deduplicate_edges_by_minor<int32_t, int32_t, false>(
raft::handle_t const&,
graph_view_t<int32_t, int32_t, false, false> const&,
rmm::device_uvector<int32_t>&&,
rmm::device_uvector<int32_t>&&,
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&,
bool);
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&);

} // namespace detail
} // namespace cugraph
9 changes: 6 additions & 3 deletions cpp/src/sampling/detail/deduplicate_edges_by_minor_sg_v64_e64.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,19 @@ template CUGRAPH_EXPORT std::tuple<rmm::device_uvector<int64_t>,
rmm::device_uvector<int64_t>,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>,
std::optional<rmm::device_uvector<int64_t>>,
rmm::device_uvector<int64_t>,
rmm::device_uvector<int64_t>,
arithmetic_device_uvector_t,
arithmetic_device_uvector_t,
std::optional<rmm::device_uvector<int32_t>>>
deduplicate_edges_by_minor<int64_t, int64_t, false>(
raft::handle_t const&,
graph_view_t<int64_t, int64_t, false, false> const&,
rmm::device_uvector<int64_t>&&,
rmm::device_uvector<int64_t>&&,
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&,
bool);
arithmetic_device_uvector_t&&,
std::optional<rmm::device_uvector<int32_t>>&&);

} // namespace detail
} // namespace cugraph
24 changes: 15 additions & 9 deletions cpp/src/sampling/detail/gather_one_hop_impl.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,15 +401,21 @@ gather_one_hop_edgelist_to_unvisited_neighbors(
}
}

std::tie(
result_majors, result_minors, tmp_edge_indices, result_labels, std::ignore, std::ignore) =
deduplicate_edges_by_minor(handle,
graph_view,
std::move(result_majors),
std::move(result_minors),
std::move(tmp_edge_indices),
std::move(result_labels),
false);
std::tie(result_majors,
result_minors,
tmp_edge_indices,
result_labels,
std::ignore,
std::ignore,
std::ignore,
std::ignore,
std::ignore) = deduplicate_edges_by_minor(handle,
graph_view,
std::move(result_majors),
std::move(result_minors),
std::move(tmp_edge_indices),
arithmetic_device_uvector_t{std::monostate{}},
std::move(result_labels));

std::tie(visited_minors, visited_minor_labels) =
detail::update_dst_visited_vertices_and_labels<vertex_t, edge_t, multi_gpu>(
Expand Down
Loading
Loading