Get all workers from scheduler info#1514
Merged
rapids-bot[bot] merged 1 commit intoJul 1, 2025
Merged
Conversation
For no good reason other than making Jupyter pretty printing nicer, dask/distributed#9045 broke the API of `client.scheduler_info()` by changing the default number of workers that are retrieved to `5`. We use this information in various places to ensure the correct number of workers have connected to the scheduler, and thus this change now specifies `n_workers=-1` to get all workers instead of just the first `5`. This happened not to be seen in CI previously because we don't run multi-GPU tests, let alone with more than `5` workers. Running various tests from `test_dask_cuda_worker.py` on a system with 8 GPUs will cause them to timeout while waiting for the workers to connect.
pentschev
added
bug
jacobtomlinson
approved these changes
Jul 1, 2025
Member
Author
|
Thanks @jacobtomlinson ! |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For no good reason other than making Jupyter pretty printing nicer, dask/distributed#9045 broke the API of
client.scheduler_info()by changing the default number of workers that are retrieved to5.We use this information in various places to ensure the correct number of workers have connected to the scheduler, and thus this change now specifies
n_workers=-1to get all workers instead of just the first5. This happened not to be seen in CI previously because we don't run multi-GPU tests, let alone with more than5workers. Running various tests fromtest_dask_cuda_worker.pyon a system with 8 GPUs will cause them to timeout while waiting for the workers to connect.