Propagate pytest filterwarnings to subprocesses via PYTHONWARNINGS #1638
Propagate pytest filterwarnings to subprocesses via PYTHONWARNINGS #1638parthsanan wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the test configuration to ensure pytest’s filterwarnings settings are propagated to Python subprocesses by exporting them via PYTHONWARNINGS, addressing warnings not being elevated to errors in subprocess-based tests (closes #1634).
Changes:
- Read
filterwarningsfrom pytest config duringpytest_configure. - Set
PYTHONWARNINGS(if not already set) to a comma-separated list of the configured warning filters so subprocesses inherit the same behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @TomAugspurger, this is ready for review when you get a chance :) |
|
/ok to test 58bba88 |
wence-
left a comment
There was a problem hiding this comment.
I think this makes sense, thanks.
|
/ok to test ca29091 |
|
/ok to test 7d15605 |
|
Thanks @parthsanan, and sorry for the delay. It looks like there's some CI failures: https://github.com/rapidsai/dask-cuda/actions/runs/25125997838/job/73639887965?pr=1638#step:12:5705 DetailsAt a glance, they look related to the changes in this PR. Are you interested in investigating those issues? |
|
Hey @TomAugspurger, thanks for taking a look and I'll absolutely push a fix for the pipeline. Will ping once done :) |
Closes #1634