refactor(rapids-artifact-name): add explicit --arch flag to override $(arch)#255
Conversation
… vs. cuda-dependent pure artifacts (rapidsai#254)" This reverts commit 2a51afa.
f9497f8 to
207ee5c
Compare
jameslamb
left a comment
There was a problem hiding this comment.
I trust your testing, if this fixes the issues let's merge this.
distributed_ucxxhas a dependency on cuda version (or is built for both cuda 12 and cuda 13, at least) but is CPU arch independent
This would be true for anything that doesn't have compiled code but does have CUDA-version-specific dependencies. nx-cugraph-{cu12,cu13} and cuopt-server-{cu12,cu13} are other examples.
Everything you said is right, just noting that we're not making changes only for the sake of distributed-ucxx.
Thanks for documenting that, @jameslamb ! Yeah, As an early open-source collaborator of mine once said, "your special case isn't special enough to allow" |
|
Love that haha |
|
/merge |
--archflag to override$(arch)Sorry for the churn on this.
This PR reverts the change in #254 for a few reasons:
distributed_ucxxhas a dependency on cuda version (or is built for both cuda 12 and cuda 13, at least) but is CPU arch independent.So, instead, after reverting that change, I'm adding an additional (and
optional)
--arch <value>flag, that, if used, overrides the value of$(arch)with the user-provided string.This could be useful for downloading artifacts with a different architecture
than the system a developer is currently using, and can also be used to set an
arbitrary value for
archfor the cases likedistributed_ucxxwhere we buildon
x86_64but use the artifacts built there on bothx64_64andaarch64systems. (This is true for anythign that doesn't have compiled code but does have CUDA-version-specific dependencies, like
nx-cugraphandcuopt-server)