Remove raft dependency#9
Open
arhag23 wants to merge 2 commits into
Open
Conversation
vyasr
reviewed
Jul 13, 2026
vyasr
left a comment
vyasr
left a comment
Contributor
There was a problem hiding this comment.
It looks like we were logging in exactly one place before, so I think we can just remove it for now or replace it with a conditional printf of some sort. Not critical. I would prefer not to depend on rapids-logger here. Copying over the macros is otherwise fine for now, thanks!
vyasr
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied over macros used from raft and adjusted exception types to just use the standard library ones. Unsure about what our policy is about throwing exceptions. Also unsure if we want to depend on rapids-logger for "RTCX_DEBUG_LOG", so for now just commented out the logging macro.