Use cudf::pack with pinned mr in TableChunk::copy#966
Open
nirandaperera wants to merge 21 commits into
Open
Conversation
Signed-off-by: niranda perera <niranda.perera@gmail.com>
nirandaperera
added
improvement
Contributor
Author
|
This PR depends on #967 because it now requires precise packed sizes for pinned memory. |
pentschev
reviewed
Apr 16, 2026
pentschev
approved these changes
Apr 16, 2026
Member
pentschev
left a comment
pentschev
left a comment
There was a problem hiding this comment.
Looks good overall, left some requests for typo fixes and phrasing improvements, and a nit.
Co-authored-by: Peter Andreas Entschev <peter@entschev.com>
…pidsmpf into table_chunk_pinned_copy
Signed-off-by: niranda perera <niranda.perera@gmail.com>
wence-
requested changes
Apr 21, 2026
Signed-off-by: niranda perera <niranda.perera@gmail.com>
…_pinned_copy Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
madsbk
approved these changes
May 13, 2026
Member
madsbk
left a comment
madsbk
left a comment
There was a problem hiding this comment.
Looks good, thanks @nirandaperera
Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
pentschev
approved these changes
May 13, 2026
Member
pentschev
left a comment
pentschev
left a comment
There was a problem hiding this comment.
Minor question/nit, looks good otherwise, thanks Niranda.
wence-
approved these changes
May 14, 2026
Comment on lines
+39
to
+40
| return accessibility == cuda::mr::__memory_accessibility::__host | ||
| || accessibility == cuda::mr::__memory_accessibility::__host_device; |
Contributor
There was a problem hiding this comment.
Is there really no public way to do this?
Contributor
Author
There was a problem hiding this comment.
Unfortunately no (at least not that I know of)
| get_property(mr, cuda::mr::dynamic_accessibility_property{}); | ||
| return accessibility == cuda::mr::__memory_accessibility::__device | ||
| || accessibility == cuda::mr::__memory_accessibility::__host_device; | ||
| } |
Contributor
There was a problem hiding this comment.
You can avoid the dynamic lookup if you if constexpr (has_property<mr, device_accessible>) otherwise fallback?
Contributor
Author
There was a problem hiding this comment.
I think get_property does exactly that https://github.com/NVIDIA/cccl/blob/main/libcudacxx/include/cuda/__memory_resource/get_property.h#L191-L196
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous analysis we found that using
cudf::packwith a pinned mem resource performs similar to,Since (1) use unreserved device memory,
TableChunk::copyis prone to OOM. This PR changes pinned memory to usecudf::packdirectly.Depends on #967