Forward failure callback alignment

[bdice]

Description

Forwards caller-provided alignment through failure_callback_resource_adaptor allocation and deallocation calls instead of always using CUDA_ALLOCATION_ALIGNMENT. This preserves alignment semantics when the adaptor is stacked with other resources.

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c661fb1d-08f8-4e28-95f6-c7ba59eeb7f3

📥 Commits

Reviewing files that changed from the base of the PR and between d4d4c0a and 6596034.

📒 Files selected for processing (1)

• cpp/include/rmm/mr/detail/failure_callback_resource_adaptor_impl.hpp

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Memory allocation now correctly respects alignment parameters throughout the failure callback mechanism, ensuring consistent alignment handling across all operations.

• Tests

  • Added tests validating alignment parameter forwarding in memory allocation operations.

Walkthrough

The PR updates failure_callback_resource_adaptor_impl to accept and forward the caller-provided alignment (defaulting to rmm::CUDA_ALLOCATION_ALIGNMENT) to upstream allocate/deallocate calls; allocate_sync/deallocate_sync defaults were updated. A new test verifies alignment forwarding using a mock resource.

Changes

Alignment parameter forwarding

Layer / File(s)	Summary
Allocate and deallocate alignment forwarding cpp/include/rmm/mr/detail/failure_callback_resource_adaptor_impl.hpp	allocate and deallocate now forward the caller-provided alignment to the upstream resource; allocate_sync/deallocate_sync default alignment changed to rmm::CUDA_ALLOCATION_ALIGNMENT.
Alignment forwarding test cpp/tests/mr/failure_callback_mr_tests.cpp	New ForwardsAlignment test adds mock_resource.hpp, gmock aliases, and EXPECT_CALL checks that the adaptor forwards the specified alignment for allocate/deallocate.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• Fix callback memory resource allocation API to match CCCL and support alignment #2397: Addresses the same alignment-forwarding behavior for adaptor/callback allocation/deallocation.

Possibly related PRs

• rapidsai/rmm#2343: Also updates wrappers to forward explicit rmm::CUDA_ALLOCATION_ALIGNMENT to underlying resources.
• rapidsai/rmm#2330: Adds alignment forwarding through allocation call paths (device_buffer constructors).

Suggested reviewers

• miscco
• rongou

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: forwarding alignment through the failure callback resource adaptor.
Description check	✅ Passed	The description is directly related to the changeset, explaining the purpose of forwarding caller-provided alignment through the adaptor.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bdice]

/merge