Skip to content

Use async APIs in random MR ref tests#2405

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:mainfrom
bdice:pr-use-async-random-mr-ref-tests
May 22, 2026
Merged

Use async APIs in random MR ref tests#2405
rapids-bot[bot] merged 2 commits into
rapidsai:mainfrom
bdice:pr-use-async-random-mr-ref-tests

Conversation

@bdice
Copy link
Copy Markdown
Collaborator

@bdice bdice commented May 17, 2026

Description

Updates the random async MR ref allocation helper to call stream-aware allocate() and deallocate() APIs instead of the synchronous APIs. This makes the random async allocation tests exercise stream-ordered resource paths as the test name indicates.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 17, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 17, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Test function test_random_async_allocations in the memory resource test suite was updated to call async allocation and deallocation APIs with explicit stream management instead of their synchronous counterparts, ensuring proper stream synchronization for non-default streams.

Changes

Async Allocation API Testing

Layer / File(s) Summary
Stream-aware async allocation test
cpp/tests/mr/mr_ref_test.hpp
test_random_async_allocations switched from synchronous allocate_sync and deallocate_sync to async allocate(stream, ...) and deallocate(stream, ...) calls; non-default streams are explicitly synchronized after each allocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • ttnghia
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating random MR ref tests to use async APIs instead of synchronous ones.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the changes: updating async MR ref allocation tests to use stream-aware async APIs instead of synchronous ones, making the tests properly exercise stream-ordered resource paths as intended.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdice bdice marked this pull request as ready for review May 21, 2026 14:20
@bdice bdice requested a review from a team as a code owner May 21, 2026 14:20
@bdice bdice requested review from davidwendt and vyasr May 21, 2026 14:20
@bdice bdice moved this to In Progress in RMM Project Board May 21, 2026
@bdice bdice self-assigned this May 21, 2026
@bdice
Copy link
Copy Markdown
Collaborator Author

bdice commented May 22, 2026

/merge

@rapids-bot rapids-bot Bot merged commit f153069 into rapidsai:main May 22, 2026
84 of 85 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in RMM Project Board May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants