feat: add override env-var for setting custom artifact name#528
Merged
Conversation
20 tasks
KyleFromNVIDIA
approved these changes
Apr 28, 2026
Member
KyleFromNVIDIA
left a comment
There was a problem hiding this comment.
Approved with a reminder for one small pitfall
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of rapidsai/build-planning#270.
I'm rolling out a new
rapids-artifact-nametool to make our artifact names more consistent - part of the first phase of this is overriding the "default" names that get created byshared-workflows. I previously added the capability to override the artifact name from within the ci scripts for the stable ABI work, but that only covered thepython-buildworkflows, this extends that capability to thecpp-buildworkflows.Tested this in rapidsai/rmm#2370 along with the vendored version of the script from rapidsai/gha-tools#253