Skip to content

feat: add override env-var for setting custom artifact name#528

Merged
rapids-bot[bot] merged 1 commit into
mainfrom
cpp_override
Apr 28, 2026
Merged

feat: add override env-var for setting custom artifact name#528
rapids-bot[bot] merged 1 commit into
mainfrom
cpp_override

Conversation

@gforsyth
Copy link
Copy Markdown
Contributor

@gforsyth gforsyth commented Apr 27, 2026

This is part of rapidsai/build-planning#270.

I'm rolling out a new rapids-artifact-name tool to make our artifact names more consistent - part of the first phase of this is overriding the "default" names that get created by shared-workflows. I previously added the capability to override the artifact name from within the ci scripts for the stable ABI work, but that only covered the python-build workflows, this extends that capability to the cpp-build workflows.

Tested this in rapidsai/rmm#2370 along with the vendored version of the script from rapidsai/gha-tools#253

@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 27, 2026
@gforsyth gforsyth marked this pull request as ready for review April 28, 2026 18:48
@gforsyth gforsyth requested a review from a team as a code owner April 28, 2026 18:48
@gforsyth gforsyth requested review from KyleFromNVIDIA and removed request for a team April 28, 2026 18:48
Copy link
Copy Markdown
Member

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a reminder for one small pitfall

Comment thread .github/workflows/conda-cpp-build.yaml
@gforsyth
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 028ab59 into main Apr 28, 2026
2 checks passed
@gforsyth gforsyth deleted the cpp_override branch April 28, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants