Open
Conversation
The old version uses a clunky set of strstrs to determine if the remote was hpnssh and if they are using hpn-prefixed binaries. It was also checking to see if it was openssh and had strict window checking. This replaces both methods using sscanf() to get the version numbers which means we shouldn't have to touch this section of code for future versions.
While not associated with the compat.c fixes this removes some more files in /regress when cleaning.
OpenSSL 4 has removed the API for EVP_CIPHER_meth*. It was deprecated in OpenSSL3 but it's gone now. Wrap the call around an 'if !defined(WITH_OPENSSL3)' and it won't get triggered except on OpenSSL 1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates compat.c to use a more flexible method to determine remote version and set the appropriate flags. Unrelated work is a minor change to Makefile.in to remove more files from regress when executing make clean.