Repository navigation
Document limitations; cover the remaining termination laws with properties - #7
Merged
Merged
Conversation
…operties - README: Limitations section with the transport matrix, lazy deadlines and synchronous cancel() in a blocking request (EN + RU) - Properties: exclusive, stable termination with once-only listeners (laws 4, 6, 7); observing a node terminates exactly the subtree owning its deadline (law 7); a throwing listener never stops the cascade (law 8) - invalidTimeoutsAreRejected covers -INF and NAN - listenerFailureDoesNotStopCascade: its assertions ran after the expected exception and were dead code
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Limitationssection right after Installation — the transport matrix (what a budget can bound, what can be aborted in flight), lazy deadlines (an unobserved context never runs its listeners) and whycancel()cannot interrupt a blocked request.terminationIsExclusiveStableAndNotifiesOnce— random trees with deadlines under random advance/cancel/late-listener operations: exactly one cause, never changing;assertActive()throws the matching exception with a memoized deadline; every listener runs once iff its node terminated; a terminated parent implies terminated children. Seven examples (cancel after expiry, expiry after cancel, cancel twice, three-level cascade, late listeners).observingANodeTerminatesExactlyTheSubtreeOwningItsDeadline— one observation terminates exactly the subtree of the deadline's owner, checked through listeners without observing other nodes.aThrowingListenerNeverStopsTheCascade— the whole subtree is notified; the exception surfaces iff a failing listener is inside the subtree.invalidTimeoutsAreRejectednow covers-INFandNAN.listenerFailureDoesNotStopCascade: its assertions ran after the expected exception and never executed; they now run infinally.Coverage gates are calibrated at 2-3x below the measured distribution. Three hand mutations in
src/(equal-deadline ownership, listener isolation removed, memoization removed) are each caught by the new properties.No
src/changes.