Repository navigation
Raise vimeo/psalm to ^7.0 - #178
Conversation
Downgrade ImmutableDependency to info for DrawnEngine: \Random\Engine::generate has the narrow stub contract (read-props|write-this-props|io), but the draw tape is static state and shrinking builds exceptions — the implementation honestly does more than the stub allows and cannot fit it without losing the tape.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Reviewer's GuideImplementationReview the DrawnEngine-specific Psalm issue-level downgrade alongside the explanation for why its static tape and exception construction exceed the Random Engine stub contract.
ConfigurationReview the Psalm dependency major-version constraint change as part of the Psalm 7 rollout.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="psalm.xml" line_range="26" />
<code_context>
+ The implementation cannot fit the interface contract without
+ losing the tape; downgraded to info for this file only. -->
+ <ImmutableDependency>
+ <errorLevel type="info">
+ <file name="src/Arbitrary/DrawnEngine.php"/>
+ </errorLevel>
</code_context>
<issue_to_address>
**Psalm misses a contract violation**
When psalm analyzes `src/Arbitrary/DrawnEngine.php`, psalm demotes `DrawnEngine`’s `ImmutableDependency` finding to info instead of resolving the effect-contract mismatch, so `composer build` passes with the finding still present.
Resolve the effect-contract mismatch at its source and remove the file-scoped issue-handler downgrade.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: psalm.xml:26
|
Note on the Sourcery thread (resolved): the |
Part of the Psalm 7 rollout (final library batch). Constraint
^6.16→^7.0, single major.composer buildgreen locally on Psalm 7.3.0.Summary by Sourcery
Enhancements: