Repository navigation
Rejection::is(): a post-call StorageFailure is not a rejection - #9
Merged
Merged
Conversation
StorageFailure from recordOutcome means the callback already ran. Mapping it as 'rejected without an attempt' invites re-executing a non-idempotent call. Only admit and the rejected-path snapshot failures count now.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
CircuitBreaker::call()throwsStorageFailurewithoperation = 'recordOutcome'after the callback has already run. 0.2.0 classified it as "rejected without an attempt", soonRejected()mapped it to the caller's "unavailable, try later" exception. That invites re-running a non-idempotent call that already reached the downstream.Rejection::is()acceptsStorageFailureonly foradmitandsnapshot. Insidecall(), thesnapshotread happens only on the rejected-admission path.recordOutcomeandforceStatefailures pass through unmapped.recordOutcomewith adownstreamOutcome.onRejected()docblock are updated.StorageFailure.Local:
composer buildgreen,release-checkgreen ("No backwards-incompatible changes detected" vs v0.2.0), mutation covered MSI 100%,package-audit0/0. Released as 0.2.1.