Skip to content

Raise vimeo/psalm to ^7.0 - #170

Merged
rasuvaeff merged 3 commits into
masterfrom
chore/psalm-7
Nov 11, 2026
Merged

rasuvaeff merged 3 commits into
masterfrom
chore/psalm-7

Conversation

@rasuvaeff

@rasuvaeff rasuvaeff commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Part of the Psalm 7 rollout (final library batch). Constraint ^6.16 → ^7.0, single major. composer build green locally on Psalm 7.3.0.

Summary by Sourcery

Enhancements:

  • Upgrade the project’s Psalm dependency to support the Psalm 7 major release.

Mirror the /** @var mixed $value */ annotation onto the second variadic
foreach in WhenBuilder: Psalm 7 flags the unannotated MixedAssignment.
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a593b642-88af-4a2c-b0f7-594e4c22d046
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sourcery-ai

sourcery-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Annotate the variadic loop value so Psalm 7 accepts the existing return-value handling.

  • src/WhenBuilder.php L104

Configuration

Upgrade Psalm to version 7 and refresh the API workspace lockfile to record the compatible dependency update.

  • composer.json L41
  • docs/.api-workspace/composer.lock L2836-3154, L3694-3703, L7087-7096 (+11 small edits)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Nov 11, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

The workspace now requires vimeo/psalm ^7.0 explicitly (the plugin does
since 1.1.0); the outdated --strict step stayed red otherwise.
sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Nov 11, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

The engine stays on the path repository (the checkout): update psalm and the
plugin together, so the partial update never needs to touch the engine pin.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@rasuvaeff
rasuvaeff merged commit 056fa15 into master Nov 11, 2026
26 checks passed
@rasuvaeff
rasuvaeff deleted the chore/psalm-7 branch November 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant