Fix notice when verifying empty request URI - #78
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a PHP notice (Uninitialized string offset: 0) triggered when validating an empty request URI path during WebSocket handshake verification (RFC6455), by explicitly rejecting empty strings before checking the leading slash.
Changes:
- Reject empty request URIs up front in
RequestVerifier::verifyRequestURI()to avoid string-offset access on''. - Add a unit test case asserting an empty URI is invalid.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Handshake/RequestVerifier.php |
Adds an early '' guard before accessing $val[0], preventing notices while preserving invalidation behavior. |
tests/unit/Handshake/RequestVerifierTest.php |
Extends the request URI data provider with an empty-string case to cover the regression. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset avoids a PHP notice when verifying a request with an empty request URI. An empty URI was already rejected as invalid, but reading the first character to check for a leading slash triggered an "Uninitialized string offset" notice before returning. An empty string is now rejected up front.
Closes #74