Work around Psr7\Request deprecation warnings - #1121
Conversation
|
@lachlan-00 Thanks for digging into this, and great to see Ratchet powering Ampache. Good to see tests for the rejected upgrade path too. The deprecations in your log are all dynamic property notices from The deprecation this PR actually works around is a different one, the Both fixes are part of the larger effort reviving Ratchet as discussed in #1054, which has been working through a lot of these along the way. Getting the releases out is the remaining piece. Closing this for now, the fix lives upstream. If you want to bring the handshake tests back as a separate PR once rfc6455 0.4.2 is out, that'd be welcome 👍 |
I've gotten around to fixing an Ampache feature that uses ratchet and becuse i'm basing it on php8.5 i'm getting a lot of deprecation warnings.
I had a look and they seem to be issues with guzzle but this pull works around them to stop the warnings occurring by taking out the http factory that's firing the warnings.
I'll file an issue with guzzle as well to see if that's simple enough for them to avoid the workaround.