Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to edit custom markers directly from the marker modal. Key changes include:
- Renaming and updating marker input types (including renaming MarkerInput to MarkerUpdateInput and adding an "icon" field).
- Updating the trip provider and modal configuration to support the new marker editing functionality.
- Removing the old AddMarker and ViewMarker modals and replacing them with a unified Marker modal, along with backend support for marker updates.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| shared/types.ts | Renaming MarkerInput to MarkerUpdateInput and updating its fields. |
| frontend/providers/trip.tsx | Adding/refactoring the trip context to include a refetch method. |
| frontend/providers/modals.tsx | Adjusting modal imports and mapping to use the new Marker component. |
| frontend/pages/whats-new.tsx | Updating release notes to announce marker edit capabilities. |
| frontend/modals/ViewMarker.tsx | Removing the old view marker modal. |
| frontend/modals/Marker.tsx | Creating the new unified marker modal for add/edit functionality. |
| frontend/modals/AddMarker.tsx | Removing the old add marker modal. |
| frontend/components/Mapbox.tsx | Updating marker click handling to pass markerId to the modal. |
| frontend/components/ItineraryDay.tsx | Modifying modal calls to pass markerId instead of the full marker object. |
| backend/routes/trips/[tripId]/markers.ts | Adding a PATCH endpoint to update marker details on the backend. |
Comments suppressed due to low confidence (1)
shared/types.ts:205
- Consider documenting the separation between MarkerUpdateInput and MarkerNotesInput since the optional 'notes' field was removed; this will clarify that note updates are handled separately.
export type MarkerUpdateInput = {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to edit custom markers from within the marker modal.