Skip to content

feat: Updated UI - #23

Draft
alexandrtovmach wants to merge 1 commit into
ray-lothian:masterfrom
alexandrtovmach:patch/styled
Draft

feat: Updated UI#23
alexandrtovmach wants to merge 1 commit into
ray-lothian:masterfrom
alexandrtovmach:patch/styled

Conversation

@alexandrtovmach

Copy link
Copy Markdown

Thank you for your amazing extension, here UI updates for the configuration page (because it looks very poor, and it's scare potential users). I decided to help with that, and here we go!

image

DRAFT: Don't merge this PR, I need to investigate about modal functionality

@ray-lothian

Copy link
Copy Markdown
Owner

True, the options page needs a new look. Note that we cannot load remote resources and it is not recommenced to customize elements on the options page. There are many different browsers and each has its styling.

Let me work on the option's UI based on your suggestions. You can modify the new design.

@alexandrtovmach

Copy link
Copy Markdown
Author

Could you provide me with a link to limitations of extensions styling, to not waste time for me, thanks

@alexandrtovmach

Copy link
Copy Markdown
Author

From my quick experience with it, all button color styling and modal window blocking by some policy

@ray-lothian

Copy link
Copy Markdown
Owner

It is not allowed to have remote resources in your extension. Even if the policy is not blocking it, the extension will get rejected due to privacy concerns.

Could you provide me with a link to limitations of extensions styling, ...

It is not a limitation. It is more of having the options page of all extensions looks similar to the users of the browser. You can definitely overwrite all the browser's styles, but for such a simple options page it is not recommended. btw, I am trying to rewrite some parts to make it more intuitive rather than just restyling.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles

ray-lothian added a commit that referenced this pull request Mar 3, 2020
@greenfox1505

Copy link
Copy Markdown

I was about to create a pull request that added

  "options_close_blocked": {
    "message": "Close after (seconds):"
  },

That's probably not worth it if this is coming any time soon?

@ray-lothian

Copy link
Copy Markdown
Owner

@greenfox1505 to add the (seconds) part?
6255a38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants