Skip to content

Update MSI build for UtilCA; bump app version to 1.6.0.0#10

Merged
raymondjstone merged 2 commits into
masterfrom
develop
Apr 6, 2026
Merged

Update MSI build for UtilCA; bump app version to 1.6.0.0#10
raymondjstone merged 2 commits into
masterfrom
develop

Conversation

@raymondjstone
Copy link
Copy Markdown
Owner

Enhanced BuildMSI.ps1 to set UtilCA based on platform and include WixToolset.Util.wixext in the WiX build process. Updated Package.appxmanifest to increase the application version from 1.5.0.0 to 1.6.0.0.

Enhanced BuildMSI.ps1 to set UtilCA based on platform and include WixToolset.Util.wixext in the WiX build process. Updated Package.appxmanifest to increase the application version from 1.5.0.0 to 1.6.0.0.
Copilot AI review requested due to automatic review settings April 6, 2026 13:54
@raymondjstone raymondjstone merged commit 5c5568c into master Apr 6, 2026
1 check passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MSI build pipeline to correctly provide the WiX Util custom action binary based on target platform and ensures the WiX Util extension is included during wix build. It also bumps the app package version to 1.6.0.0 so the installer/product version aligns with the new release.

Changes:

  • Bump Package.appxmanifest version from 1.5.0.0 to 1.6.0.0.
  • Update BuildMSI.ps1 to set UtilCA based on platform (x86 vs x64).
  • Add WixToolset.Util.wixext to the wix build invocation so $(var.UtilCA) resolves.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

File Description
Package.appxmanifest Version bump to 1.6.0.0 for the app identity/package.
BuildMSI.ps1 Passes UtilCA define and includes WixToolset.Util.wixext during MSI build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread BuildMSI.ps1
Comment on lines +144 to +145
$utilCA = if ($Platform -eq "x86") { "Wix4UtilCA_X86" } else { "Wix4UtilCA_X64" }

Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$utilCA defaults to the x64 CA for any platform other than "x86". If someone passes an unsupported value (e.g., "arm64", "AnyCPU", typo), the script will likely produce a broken build (wrong BinaryRef for $(var.UtilCA) and/or invalid -arch/-r). Consider constraining $Platform with ValidateSet("x86","x64") and/or using an explicit switch with a throw on unsupported platforms.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants