Repository navigation
Improve interactivity in face of concurrent diagnostics - #421
Merged
Merged
Conversation
Process workspace/diagnostic projects sequentially instead of an unbounded per-project Async.Start fan-out, and disable Roslyn's internal concurrentAnalysis for both analyzer entry points. Together these cap analyzer-driven diagnostic work to one core system-wide, so it no longer starves interactive requests (completion, hover, ...) sharing the same ThreadPool. See plans/interactive-request-latency-vs-analyzers.md (Option C) for the full analysis and history of the abandoned Option A/B attempts. 🤖 Generated with [ECA](https://eca.dev) (anthropic/claude-sonnet-5) Co-Authored-By: eca-agent <git@eca.dev>
With workspace/diagnostic now analyzing one project at a time, there's no longer a second project's analyzer pass competing for cores, so Roslyn's own per-project analyzer concurrency no longer has anything to starve. Validated against a real multi-project session: completion stays responsive throughout a full analyzer-enabled sweep. Leaving concurrentAnalysis at Roslyn's default avoids needlessly slowing down each project's sweep. Also adds a CHANGELOG.md entry for the interactive-request-latency fix. 🤖 Generated with [ECA](https://eca.dev) (anthropic/claude-sonnet-5) Co-Authored-By: eca-agent <git@eca.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process workspace/diagnostic projects sequentially instead of an unbounded per-project Async.Start fan-out. This caps analyzer-driven diagnostic work, so it no longer starves interactive requests (completion, hover, ...) sharing the same ThreadPool. See plans/interactive-request-latency-vs-analyzers.md (Option C) for the full analysis and history of the abandoned Option A/B attempts.
🤖 Generated with ECA (anthropic/claude-sonnet-5)