Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is L3 from the 2026-10-24 security review.
The mod store holds 4 MiB of JSON in all, and
$.store.setrejects once a write would pass that. The guard caught each failed write and logged it only to the debug log. Oncepublishfailed, other sessions stopped counting this session's agents, so the machine-wide caps undercounted with no visible sign. (Today's store is 135 KB, so this is far off, but the failure was silent.)Changes
save(), which records the last failure and clears it once a write works.store not saving: other sessions can't count this one, and/agent-guard statusadds aStore:line with the error. Both clear on the next successful write, and the status line redraws when the state changes.storeFullswitch that makesstore.setreject.Nothing about the gates changes.
Test plan
/agent-guard statussay so; once a write works again, the line clearsclaude plugin test .on 2.1.310: 104 pass. Withhooks/register.tsandcore/status.tsstashed, the new test fails.claude plugin validate . --strictandtscare clean