feat(ciena): add tl1MaxConnections and a Ciena vendor README - #76
Closed
stephenstack wants to merge 1 commit into
Closed
stephenstack wants to merge 1 commit into
stephenstack wants to merge 1 commit into
Conversation
Every RNE behind a Ciena GNE opens its own TL1 session to that gateway, so a nightly run over a gateway fronting a hundred RNEs attempts a hundred logins as fast as the queue can issue them. A node that refuses connections past its own cap fails whichever collections lose that race. rConfig now caps concurrent sessions per gateway, configured with connect.tl1MaxConnections on the GNE's template and defaulting to 20. Both Ciena templates carry it, and the key is documented in the legend with its clamping behaviour: values outside 1 to 500 are clamped and anything non-numeric falls back to the default, so a typo cannot stop a gateway collecting. The validator's allowlist gains the key too, otherwise these templates would fail their own CI. Key counts in README, CONTRIBUTING, EDITIONS and the legend move from 46 to 47, and the Pro-only count from 13 to 14. The CHANGELOG's count is left alone, being a record of a past release. Ciena had no vendor README while most other vendors do. Added one covering what makes TL1 different from a CLI, the GNE/RNE and dual-homing model, and how to choose a connection limit. Refs RCO-1449 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports the per-gateway connection limit landing in rConfig (RCO-1449, rConfigHub/rconfig8#645).
Why
Every RNE behind a Ciena GNE opens its own TL1 session to that gateway. A nightly run over a gateway fronting a hundred RNEs attempts a hundred logins as fast as the queue can issue them, and a node that refuses connections past its own cap fails whichever collections lose that race.
rConfig now caps concurrent sessions per gateway, configured with
connect.tl1MaxConnectionson the GNE's template, default20.Changes
Both Ciena templates gain the key.
docs/TEMPLATES.mdgains the legend row, including the clamping behaviour: values outside 1 to 500 are clamped and anything non-numeric falls back to the default, so a typo cannot stop a gateway collecting.scripts/validate_templates.pygains the key in its allowlist. Without this the two templates in this PR would fail the repo's own validation, which is a CI gate. Validator run: 78 templates checked, 0 errors, 2 pre-existing warnings.Key counts move 46 → 47 in
README.md,docs/CONTRIBUTING.md,docs/EDITIONS.mdand the legend, and Pro-only 13 → 14 inEDITIONS.mdalong with its per-key list. TheCHANGELOG.mdcount is deliberately left alone, being a record of a past release.ciena/README.mdis new. Ciena had no vendor README while most other vendors do, so this fills a real gap rather than just documenting the new key: what makes TL1 different from a CLI (no enable mode, no pager, in-bandACT-USERlogin, quoted passwords), the GNE/RNE and dual-homing model, and how to choose a connection limit.Note
The root README states it "carries no key documentation" and defers to the legend, so no key documentation was added there. Only its key count changed.
🤖 Generated with Claude Code