feat(tl1): Infinera and Cisco ONS templates, and TL1 stops being a Ciena exception (RCO-1454)

[stephenstack]

Closes RCO-1454. Stage 4 of RCO-1450 (multi-vendor TL1). Pairs with rconfig8 #647, which added the tl1Vendor key this uses.

The framing change

TL1 templates were described as a standing exception to the directory rule, in three separate places: Pro-only templates living in a vendor directory. With three TL1 vendors that does not survive, and it was never really an exception.

Edition follows the capability a template uses, never the directory it sits in. cisco/ is now a mixed-edition directory, deliberately, and docs/EDITIONS.md says so instead of calling it out as a special case.

New templates

Template	Status
infinera/infinera-dtnx-tl1-ssh.yml	community-tested
infinera/infinera-dtnx-tl1-telnet.yml	community-tested
cisco/cisco-ons15454-tl1-ssh.yml	untested-starter
cisco/cisco-ons15454-tl1-telnet.yml	untested-starter

The Cisco pair ships as untested-starter on purpose. It was built from the Cisco ONS SONET TL1 Command Guide R9.1 and Oracle's ONS 15454 TL1 reference, not from a session capture. Documented is better than invented and weaker than seen on hardware. The status vocabulary exists for exactly this, and the caveat is in the template headers as well as cisco/README.md, so nobody has to read the PR to find it.

connect.tl1Vendor, the 48th key

ciena (default), infinera, cisco-ons. Selects the neighbour verb, the record format, the node's prompt, and whether a routed reply's header SID can be verified at all.

An unrecognised value fails the collection rather than falling back to Ciena. A typo collecting as the wrong vendor would parse nothing, report no elements, and flag every element behind that gateway as missing on the next run.

Ciena's templates gain tl1Vendor: ciena and drop tl1NeighbourCmd. Its old default, RTRV-NBR:ALL, named a command no shipped node answers. Each vendor's real command is the default now, and rConfig substitutes it with a logged warning for templates still naming the old verb.

Prose

docs/TL1.md is new — the vendor-neutral half of what ciena/README.md used to state as universal (in-band login, gateways, dual-homing, connection limits), plus a table of what actually differs between the three platforms. ciena/README.md keeps only what a 6500 does differently, which turns out to be the password quirk, the RTRV-NE-LIST record shape, and echoing the TID in a routed response header.

cisco/README.md rewritten. It was 15 lines of caveats with three typos (qupte, shwo, far to long) and no template table. It now lists all ten Cisco templates with their edition, and keeps the FTD prompt and WLC guidance, which were the only content worth keeping.

Validator

Now requires a vendor template's filename to start with its directory name. Every file in the library already satisfied it, so it costs nothing, and it catches a Ciena template dropped into cisco/ — which would otherwise parse, validate, and be findable by nobody. Confirmed it errors on a deliberate misfile rather than assuming.

Counts that disagreed with each other before this change

• The key count was stated as 47 in four files, while EDITIONS.md had a heading saying "The 13 Pro-only keys" above a paragraph saying 14. The real figure was 14; with tl1Vendor it is 15 of 48. All four files now agree.
• The README template badge said 69 against a real count of 70. It is 74 now.

Verification

validate_templates.py: 83 templates, 0 errors, 2 pre-existing warnings. Every relative markdown link in the repo resolves. ASCII only, per CLAUDE.md.

🤖 Generated with Claude Code