Repository navigation
refactor(auth): clarify module responsibilities - #26
Merged
Merged
Conversation
rd-code-23
marked this pull request as ready for review
August 19, 2026 03:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
auth/googleauth/session.routes,.service, and.middlewarefilename suffixesWhy
The previous auth filenames identified the feature but not each module’s role. This structure keeps vertical feature organization while making routes, services, middleware, and tests immediately recognizable without adding unnecessary controller or repository layers.
Developer impact
New or modified feature files should use descriptive role suffixes where helpful and focused capability subfolders as features grow. Empty architectural layers are not required.
Validation
pnpm --filter @goforlift/api lintpnpm --filter @goforlift/api typecheckpnpm --filter @goforlift/api test— 34 tests passedpnpm --filter @goforlift/api build