Repository navigation
feat(auth): add authentication and authorization guards - #28
Merged
Merged
Conversation
rd-code-23
marked this pull request as ready for review
August 19, 2026 04:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
requireAuthenticationmiddleware backed byrequest.session.userIdrequireAuthorizationmiddleware401 authentication_requiredand403 forbiddenresponses401versus403policyWhy
Future routines, workouts, history, and settings endpoints need one standard server-side boundary for identity and resource ownership. The guards ensure ownership queries use the user ID from the server-side session rather than trusting client-provided values.
Developer impact
Protected routes attach
requireAuthentication. User-owned resource routes additionally attachrequireAuthorizationand scope their ownership query with the typed session user ID.No fake protected endpoint was added to the production application; representative protected behavior exists only in integration tests.
Validation
pnpm --filter @goforlift/api lintpnpm --filter @goforlift/api typecheckpnpm --filter @goforlift/api test— 47 tests passedpnpm --filter @goforlift/api buildCloses #11