Repository navigation
feat(api): add exercise list endpoint - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the first read-only exercise API used by the routine-building flow. This PR intentionally keeps the scope to the shared response contract and
GET /exercises; file-structure reorganization will be handled separately.Closes #64.
What changed
GET /exercisesrouting.How the request flows
GET /exercisesthrough the exercise router mounted inapp.ts.requireAuthenticationrejects requests without a valid server-side session.ownerUserIddatabase field into the browser-safeisCustomboolean.exerciseListResponseSchemabefore returning it.This split keeps HTTP concerns in the route, database filtering in the service, and the browser/API agreement in the shared contracts package.
Security and data exposure
The ownership filter is performed by the server rather than trusted to the browser. The response deliberately excludes
ownerUserId, timestamps, and database row types. Consumers receive only:idnamedescriptionisCustomAnonymous requests receive
401 authentication_required.Verification
Deferred