Repository navigation
fix(api): limit JSON request size - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Express's JSON request limit explicit and returns accurate client errors for malformed or oversized request bodies.
This PR intentionally does not add arbitrary maximum lengths to every text field or PostgreSQL column. The overall request limit addresses the payload-size security concern; field limits remain product decisions.
Closes #69.
What changed
express.json()with an explicit 100 KB limit.400 invalid_jsonhandling for malformed JSON.413 request_too_largehandling for oversized JSON.500 internal_server_errorresponse for unexpected failures.Why both request and name limits remain
The 100 KB request limit protects the server from unusually large JSON payloads across current and future endpoints.
The exercise-name limit is a separate product rule: names are short labels displayed throughout the UI. Descriptions remain unrestricted strings, and the PostgreSQL columns remain
text. We are not establishing a blanket rule that every text field needs a database length constraint.Error behavior
400 { "error": "invalid_json" }413 { "error": "request_too_large" }500 { "error": "internal_server_error" }Verification
Out of scope