Repository navigation
feat(web): add registered user sign out - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
How sign-out works
The protected application layout owns the logout mutation and passes a registered-user logout callback into the application shell. The profile menu chooses its action from the current identity:
POST /auth/logout.The existing logout mutation obtains a CSRF token, invalidates the server-side session, and changes the authoritative current-user query cache to
{ user: null }. The application access boundary then observes the anonymous identity and redirects the browser to the welcome page.This keeps session state in TanStack Query rather than duplicating it inside the profile component.
Guest access cleanup
Previously,
ApplicationAccessBoundarycalleduseCurrentUser()before checking guest mode. That meant a guest could enter the application immediately, but an unnecessary account-session request still ran in the background.Guest detection now happens in the outer boundary. Only the registered-user access component mounts
useCurrentUser(), so guest mode no longer creates an irrelevant authentication query.Validation
pnpm lintpnpm typecheckpnpm test— 106 tests passed across contracts, API, and webpnpm build